test(leader-election): cover follower leader observation - #203
Merged
GatewayJ merged 1 commit intoJul 29, 2026
Conversation
Member
Author
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
Following("node-1"), expose the leader throughcurrent_leader(), and never report themselves as leaders.on_new_leader("node-1")callback while preserving the stopped callback contract.The production behavior was already corrected by #194. This change completes the explicit three-instance acceptance coverage for rustfs/backlog#1083 without changing production code or public APIs.
Checklist
make pre-commit(fmt-check + clippy + test + console-lint + console-fmt-check)[Unreleased](N/A: test-only change)Impact
Verification
make pre-commit cargo test -p kube-leader-election test_spawn_reports_remote_leader_to_all_followers -- --exactThe focused three-instance test was also run 100 consecutive times successfully.
Additional Notes
The test starts
node-1first and waits forLeadingbefore starting two followers. Followers are stopped and joined before the leader to avoid release or takeover races.Thank you for your contribution! Please ensure the community standards (CODE_OF_CONDUCT.md) are followed and the CLA is signed if this is your first contribution.